Renames the minumumSizeHint method to minimumSizeHint #28732
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for the PR! I think since this is public API, it technically needs a deprecation period? Since the function is being renamed? Which is technically a kinda removal I think? https://matplotlib.org/devdocs/devel/api_changes.html#deprecate-api Here I think we can get away with aliasing the old name to the new one and deprecating there, but unsure? |
|
No, this should not have a deprecation. This is a Qt API: https://doc.qt.io/qt-6/qwidget.html#minimumSizeHint-prop Qt calls this to determine the size. With the typo the function was basically unused. No user should have called this. |
…732-on-v3.9.x Backport PR #28732 on branch v3.9.x (Renames the minumumSizeHint method to minimumSizeHint)
PR summary
PR checklist