Skip to content

need to backport docathon PRs #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WeatherGod opened this issue Mar 7, 2017 · 12 comments
Closed

need to backport docathon PRs #8223

WeatherGod opened this issue Mar 7, 2017 · 12 comments
Assignees
@dstansby
Labels
Documentation

Comments

@WeatherGod
Copy link
Member

Rather than backporting each individual docathon PR, we will do one large docathon merge at the end of the week. Let's keep a list here of the docathon PRs that were accepted.
@WeatherGod
Copy link
Member Author

WeatherGod commented Mar 7, 2017 •
edited by dstansby
Loading

#8219

@QuLogic
Copy link
Member

QuLogic commented Mar 7, 2017 •
edited by dstansby
Loading

#8212

@dstansby
Copy link
Member

dstansby commented Mar 7, 2017 •
edited
Loading

#8215

@anntzer
Copy link
Contributor

anntzer commented Mar 8, 2017 •
edited by dstansby
Loading

#8233

@NelleV
Copy link
Member

NelleV commented Mar 8, 2017

As mentionned on gitter, I feel uncomfortable backporting documentation pull request. We've identified a bug in the 2.0.0 documentation reference in a ticket (#8235), and if we backport the pull request that fixes this bug, we loose the information allowing to identify when the bug was discovered.

@NelleV
Copy link
Member

NelleV commented Mar 8, 2017

(That's without considering the risk of backporting documentation that uses new features).

@dstansby
Copy link
Member

dstansby commented Mar 8, 2017 •
edited
Loading

#8211

@dstansby
Copy link
Member

dstansby commented Mar 8, 2017

Would backporting to 2.0.x instead be fine?

@anntzer
Copy link
Contributor

anntzer commented Mar 8, 2017 •
edited by QuLogic
Loading

#8228 -- renames don't get backported -- @QuLogic.

@dstansby
Copy link
Member

The docathon has long gone, so I'm happy to port these all back to 2.0.x - if anyone has any objections then shout, otherwise I will do them in a couple of days!

@dstansby dstansby self-assigned this Apr 10, 2017
@dstansby
Copy link
Member

dstansby commented May 1, 2017

Great, these are all backported, thanks to everyone who did the original PRs, and sorry for the delay on my end...

@dstansby dstansby closed this as completed May 1, 2017
@QuLogic
Copy link
Member

QuLogic commented May 1, 2017

Thanks @dstansby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstansby dstansby

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@NelleV @WeatherGod @QuLogic @anntzer @dstansby