Skip to content

mkdir is in the stdlib in Py3. #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2018
Merged

mkdir is in the stdlib in Py3. #10439

merged 1 commit into from
Feb 15, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 13, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone Feb 13, 2018
@WeatherGod
Copy link
Member

Errors in tests: TypeError("mkdir() got an unexpected keyword argument 'exist_ok'",)

@tacaswell
Copy link
Member

This presumably needs #10425 to go in first?

@anntzer
Copy link
Contributor Author

anntzer commented Feb 13, 2018

yup.

@QuLogic
Copy link
Member

QuLogic commented Feb 15, 2018

Can rebase now.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 15, 2018

done

@QuLogic QuLogic mentioned this pull request Feb 15, 2018
Merged
1 task
QuLogic
QuLogic approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should wait for #10470 to not break Py2.

@timhoffm timhoffm merged commit 78c484e into matplotlib:master Feb 15, 2018
@anntzer anntzer deleted the mkdir branch February 15, 2018 17:18
@QuLogic QuLogic added the Py3k label Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @WeatherGod @tacaswell @QuLogic @timhoffm