bug fix - set_facecolors not working for 3D scatter #10489
Conversation
|
@xiaoshiqi thanks for the patch! I think this will be a very useful addition. Could you add a test that confirms that this works as expected? I'm not sure if you need to make a full-on image comparison test for this, but a test should at least create a 3D artist with a certain face and edge color, set them to something different, and the confirm that the changes stick as a expected. The mplot3d tests are here: |
|
no problem, I will work on it asap |
rollback docstring to original add a test case
|
I am not quite understanding the code design here. Why wasn't this added to the Patch3DCollection class directly? |
|
@WeatherGod I'm afraid that other artists may be affected if I modify Patch3DCollection. |
|
@WeatherGod I have attempted another fix. Could you please review this? |
|
@WeatherGod it's now fixed |
|
why is this closed? did another PR fix the problem? Sorry I have been quiet lately, multiple snowstorms and sicknesses have eaten up my free time. |
|
@WeatherGod I'm sorry, I thought this PR is rejected, so I started another one #10797 |
|
sorry for that impression. sometimes responses get a little slow around
here. I'll review your other PR tomorrow.
…On Thu, Mar 15, 2018 at 9:46 PM, Shiqi Xiao ***@***.***> wrote:
@WeatherGod <https://github.com/weathergod> I'm sorry, I thought this PR
is rejected, so I started another one #10797
<#10797>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10489 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-P5pt_e1H7Kv7HFPo8gsF1ffx9x0ks5texlcgaJpZM4SH2SV>
.
|
|
@WeatherGod thanks |
PR Summary
fixed set_facecolor(set_facecolors), set_edgecolor(set_edgecolors), and set_color not working for scatter patch in 3D #9725
_facecolor3d, _edgecolor3d should be updated alone with color changes.
PR Checklist