Add test to imread from url. #10817
Merged
Add test to imread from url. #10817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't we have other tests that utilizes the internet? I think we mark them
as such so Debian doesn't have to run those tests.
…On Sat, Mar 17, 2018 at 4:51 AM, Antony Lee ***@***.***> wrote:
PR Summary
Replaces #4485 <#4485>. Note
that we *already* have a test there that requires internet access (but
reading from the filelike object returned by urllib.request) so adding
another test requiring internet request can't change our status wrt debian
policies (discussed in the previous thread).
PR Checklist
- Has Pytest style unit tests
- Code is PEP 8 compliant
- New features are documented, with examples if plot related
- Documentation is sphinx and numpydoc compliant
- Added an entry to doc/users/next_whats_new/ if major new feature
(follow instructions in README.rst there)
- Documented in doc/api/api_changes.rst if API changed in a
backward-incompatible way
------------------------------
You can view, comment on, or merge this pull request online at:
#10817
Commit Summary
- Add test to imread from url.
File Changes
- *M* lib/matplotlib/tests/test_image.py
<https://github.com/matplotlib/matplotlib/pull/10817/files#diff-0>
(11)
Patch Links:
- https://github.com/matplotlib/matplotlib/pull/10817.patch
- https://github.com/matplotlib/matplotlib/pull/10817.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10817>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-Hmu7ccGg-iDkhq_lRPUgBQHlnDzks5tfM6JgaJpZM4SuuY->
.
|
tacaswell
approved these changes
Mar 17, 2018
WeatherGod
approved these changes
Mar 17, 2018
|
way back in the day, this was an issue when you couldn't exclude those sorts of tests. and this test was already one of those, so I am not sure why it was brought up. All this does is expands the smoketest a little bit so that it proves that a url is all that is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Replaces #4485. Note that we already have a test there that requires internet access (but reading from the filelike object returned by urllib.request) so adding another test requiring internet request can't change our status wrt debian policies (discussed in the previous thread).
PR Checklist