Skip to content

Fix undefined name error in backend_pgf. #11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

Fix undefined name error in backend_pgf. #11185

merged 1 commit into from
May 7, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 7, 2018

PR Summary

Closes #11183, followup to #10339, sorry :)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: pgf labels May 7, 2018
@anntzer anntzer added this to the v3.0 milestone May 7, 2018
timhoffm
timhoffm approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revenge for skipping the bonus points for a test case in the original PR 😄. It all comes back ...

@jklymak jklymak merged commit d0c2f66 into matplotlib:master May 7, 2018
@anntzer anntzer deleted the pgffix branch May 7, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: pgf Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Undefined name 'system_fonts' in backend_pgf.py
3 participants
@anntzer @timhoffm @jklymak