Skip to content

Test that boilerplate.py is correctly run. #11204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 9, 2018

(and update the outdated pyplot.py).

Closes #3701.
@tacaswell convinced me that a boilerplate.py-generated pyplot is nicer to introspection tools.
It's also a bit tricky to run boilerplate.py as part of setup.py (as suggested in #3701) because it can only be run at a point where _axes.py is actually importable (for introspection), but for example when building a sdist _axes.py is never importable because that never builds the extension modules.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone May 9, 2018
(and update the outdated pyplot.py).
@anntzer anntzer force-pushed the boilerplate-test branch from 76002fb to 0e8cd4a Compare May 9, 2018 06:33
@tacaswell tacaswell merged commit 920295d into matplotlib:master May 13, 2018
@anntzer anntzer deleted the boilerplate-test branch May 13, 2018 22:15
@jklymak jklymak mentioned this pull request May 14, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit tests should compare pyplot.py with output from boilerplate.py
3 participants