Avoid recursion for subclasses of str that are also "PathLike" in to_filehandle() #11307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the case for path.py for example. Fixes matplotlibgh-11306
6 tasks
anntzer
approved these changes
May 25, 2018
|
Thanks @Nodd ! |
|
@anntzer should be backported? |
|
I guess it counts as a regression in 2.2, so backporting is probably a good idea. |
|
@meeseeksdev backport to 2.2.x |
|
Something went wrong ... Please have a look at my logs. |
|
Grr, need to spell the bot name and the branch name correctly... @meeseeksdev backport to v2.2.x |
|
There seem to be a conflict, please backport manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the case for path.py for example.
Fixes gh-11306
PR Summary
If the path to
savefigis both a subclass ofstrand aPathLikeobject,to_filehandle()creates an infinite recursion.The PR simplifies the code while avoiding this corner case.
PR Checklist