Skip to content

Don't recurse in to_filehandle for PathLikes. #11308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't recurse in to_filehandle for PathLikes. #11308

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 25, 2018

PR Summary

I think this should fix #11306 (@Nodd can you confirm?)
My original recursive thing seems a bit gratuitious.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
Contributor Author

anntzer commented May 25, 2018

#11307 was faster than me :)

@anntzer anntzer closed this May 25, 2018
@anntzer anntzer deleted the to_filehandle branch May 25, 2018 09:23
@Nodd
Copy link
Contributor

Nodd commented May 25, 2018

9 minutes faster ! 😄
Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

savefig and path.py
2 participants
@anntzer @Nodd