Fix tox configuration #11362
Merged
Fix tox configuration #11362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jun 4, 2018
| setenv = | ||
| MPLCONFIGDIR={envtmpdir}/.matplotlib | ||
| PIP_USER = 0 | ||
| PIP_ISOLATED = 1 |
There was a problem hiding this comment.
Not sure you really want to set PIP_ISOLATED? This would also ignore whatever proxies are set in the config file (actually you are the one who raised that point :-))
The thing with PIP_USER=0 is that it's actually absolutely necessary to override --user to make tox work at all, whereas other settings may not need being overridden.
There was a problem hiding this comment.
Good call, dropping that bit.
Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
anntzer
approved these changes
Jun 4, 2018
phobson
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently
toxwill delete the font cache in~/.matplotlibif invoked. Likely the tests should not be relying on or using anything from~/.matplotlib, much less modifying the user's environment. This PR setsMPLCONFIGDIRto a temporary directory created bytoxthat is cleared on every invocation.I was unable to test it because of #11361, and because
toxis not invoked anywhere as part of the CI as far as I can tell.Update
Closes #11361. With help from @anntzer, these changes now also fix the problem with running
tox.