Skip to content

Fix tox configuration #11362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Fix tox configuration #11362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51dfcc8
Switch tox to using custom configuration directory
pganssle Jun 1, 2018
4b77bf4
Make tox.ini work out of the box
pganssle Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ envlist = py35, py36

[testenv]
changedir = /tmp
setenv =
MPLCONFIGDIR={envtmpdir}/.matplotlib
PIP_USER = 0
PIP_ISOLATED = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you really want to set PIP_ISOLATED? This would also ignore whatever proxies are set in the config file (actually you are the one who raised that point :-))
The thing with PIP_USER=0 is that it's actually absolutely necessary to override --user to make tox work at all, whereas other settings may not need being overridden.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, dropping that bit.

MPLLOCALFREETYPE = 1
usedevelop = True
commands =
sh -c 'rm -f $HOME/.matplotlib/fontList*'
{envpython} {toxinidir}/tests.py --processes=-1 --process-timeout=300
pytest --pyargs matplotlib
deps =
numpy
pytest