Skip to content

Doc: Remove huge note box from examples. #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ImportanceOfBeingErnest
Copy link
Member

PR Summary

Sphinx-gallery introduced a Note-Box on top of all examples linking to the bottom of each page from where to download the code.

image

I find this unnecessary and disturbing. After all, a page should start with its title, not a note. Since there is no way to move that box somewhere else, my proposal is to remove it entirely.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to merge. If someone objects we can revisit, but I don't think the big Note looks good, and is redundant with our buttons below the examples

@jklymak jklymak merged commit 7b96f00 into matplotlib:master Jun 12, 2018
@ImportanceOfBeingErnest ImportanceOfBeingErnest deleted the doc_remove-huge-note-box-from-examples branch June 15, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants