Skip to content

Keyword arguments for Matplotlib.pyplot.quiver #11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Keyword arguments for Matplotlib.pyplot.quiver #11656

wants to merge 2 commits into from

Conversation

jaideep-seth
Copy link

@jaideep-seth jaideep-seth commented Jul 14, 2018

PR Summary

Closes #11526

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jaideep-seth
Copy link
Author

#11526
this is my first attempt at Matplotlib, is the PR alright?

-Thank you!

@jklymak
Copy link
Member

jklymak commented Jul 14, 2018

Thanks so much for the PR. This really needs to pass the tests, and probably needs some new tests. If at all possible, setup the testing environment for your self, and run some of the tests that have failed (drill down in continuous-integration/travis-ci/pr, is usually the most straightforward). Its usually easiest to run one or two tests at a time i.e.

pytest -v lib/matplotlib/tests/test_tightlayout.py::test_badsubplotgrid

just runs that one test.

Let us know if you have any questions.

@jklymak
Copy link
Member

jklymak commented Jul 14, 2018

Also, please fill out the PR description.

indexgrid = np.meshgrid(np.arange(nc), np.arange(nr))
X, Y = [np.ravel(a) for a in indexgrid]

elif len(args) == 0:#only keyword arguments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there really only these two possibilities? What if the user provides both kwargs and positional args?

@jklymak jklymak changed the title Keyword arguments for Matplotlib.pyplot.quiver #11526 Keyword arguments for Matplotlib.pyplot.quiver Jul 15, 2018
@jaideep-seth
Copy link
Author

jaideep-seth commented Jul 16, 2018

@jklymak Hey, thank you for the guidance!

-Thank you!

Oddly though when i do 'from matplotlib import ft2font' from within the same virtual environment it gets imported just fine, yet when i run 'py.test' it throws an import error.

https://stackoverflow.com/questions/41748464/pytest-cannot-import-module-while-python-can says not to put a init.py in tests when using pytest. - This worked for me although new errors show up.

-> ImportError: cannot import name 'check_figures_equal' and ImportError: cannot import name 'validate_markevery'. Am i doing something wrong?

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing to reject per #11526 (comment). Thank you for your contribution, but I think the problem was ill-posed to start with... Sorry!

@anntzer
Copy link
Contributor

anntzer commented Aug 29, 2018

Closing per decision in #11526.

@anntzer anntzer closed this Aug 29, 2018
@QuLogic QuLogic removed this from the v3.1 milestone Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib.pyplot.quiver does not accept X, Y, U, V and C as keyword arguments
4 participants