-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Keyword arguments for Matplotlib.pyplot.quiver #11656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#11526 -Thank you! |
Thanks so much for the PR. This really needs to pass the tests, and probably needs some new tests. If at all possible, setup the testing environment for your self, and run some of the tests that have failed (drill down in
just runs that one test. Let us know if you have any questions. |
Also, please fill out the PR description. |
indexgrid = np.meshgrid(np.arange(nc), np.arange(nr)) | ||
X, Y = [np.ravel(a) for a in indexgrid] | ||
|
||
elif len(args) == 0:#only keyword arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there really only these two possibilities? What if the user provides both kwargs and positional args?
@jklymak Hey, thank you for the guidance!
-Thank you! Oddly though when i do 'from matplotlib import ft2font' from within the same virtual environment it gets imported just fine, yet when i run 'py.test' it throws an import error. https://stackoverflow.com/questions/41748464/pytest-cannot-import-module-while-python-can says not to put a init.py in tests when using pytest. - This worked for me although new errors show up. -> ImportError: cannot import name 'check_figures_equal' and ImportError: cannot import name 'validate_markevery'. Am i doing something wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing to reject per #11526 (comment). Thank you for your contribution, but I think the problem was ill-posed to start with... Sorry!
Closing per decision in #11526. |
PR Summary
Closes #11526
PR Checklist