Skip to content

Remove unused imports #12032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2018
Merged

Remove unused imports #12032

merged 3 commits into from
Sep 14, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 6, 2018

PR Summary

Remove unused standard library imports, other imports from tests, and some other hopefully-safe cross-library imports.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.1 milestone Sep 6, 2018
@timhoffm
Copy link
Member

timhoffm commented Sep 6, 2018

largely redundant with #11994.

@QuLogic
Copy link
Member Author

QuLogic commented Sep 6, 2018

Yes, much of it probably is, but I see you didn't hit the examples and maybe a few others? I'll leave this till after that one is merged if anything else is left.

@timhoffm timhoffm mentioned this pull request Sep 6, 2018
Merged
NelleV
NelleV approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QuLogic !

@NelleV NelleV merged commit 4eee751 into matplotlib:master Sep 14, 2018
@NelleV
Copy link
Member

NelleV commented Sep 14, 2018

I bet we're going to break someone's code by removing those imports 😭

@QuLogic QuLogic deleted the unused-imports branch September 14, 2018 15:59
@jklymak
Copy link
Member

jklymak commented Sep 14, 2018

ummm, well it killed all the tests. Not sure how it passed its own tests...

@jklymak jklymak mentioned this pull request Sep 14, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @timhoffm @NelleV @jklymak