Skip to content

Handle utf-8 output by kpathsea on Windows. #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

Handle utf-8 output by kpathsea on Windows. #12253

merged 1 commit into from
Sep 27, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 24, 2018

PR Summary

cf #11848, especially #11848 (comment). Unfortunately, I haven't been able to find documentation on kpathsea's behavior wrt. encoding, beyond trying to look at the sources.

Thanks to @MortenSHUTE for the original report.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer commented Sep 24, 2018
View reviewed changes
timhoffm
timhoffm reviewed Sep 24, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. To be on the safe side, should we ask on the kpathsea mailing list?

@anntzer
Copy link
Contributor Author

anntzer commented Sep 25, 2018

You get to do it :)

@anntzer anntzer mentioned this pull request Sep 26, 2018
Closed
6 tasks
Kojoley
Kojoley reviewed Sep 26, 2018
View reviewed changes
@Kojoley Kojoley added this to the v3.0.x milestone Sep 26, 2018
@timhoffm
Copy link
Member

Asked on the kpathsea mailing list: https://tug.org/pipermail/tex-k/2018-September/002907.html

@tacaswell tacaswell merged commit 19420b9 into matplotlib:master Sep 27, 2018
@tacaswell
Copy link
Member

Thanks @anntzer !

Good to see you around again @Kojoley

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 27, 2018
@tacaswell
Backport PR matplotlib#12253: Handle utf-8 output by kpathsea on Wind…
3d552ac 
…ows.
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 27, 2018
Closed
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 27, 2018

Something went wrong ... Please have a look at my logs.

@anntzer anntzer deleted the kpathsea-encoding branch September 27, 2018 08:01
@pharshalp pharshalp mentioned this pull request Sep 27, 2018
Closed
@Kojoley Kojoley mentioned this pull request Sep 30, 2018
Merged
@timhoffm
Copy link
Member

From the answer in the mailinglist It seems not to be correct to assume utf-8 output on windows.

@Kojoley
Copy link
Member

Kojoley commented Sep 30, 2018

@timhoffm #12351 #11848 (comment)

@anntzer anntzer mentioned this pull request Oct 1, 2018
Closed
6 tasks
@jklymak jklymak modified the milestones: v3.0.x, v3.1 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

@Kojoley Kojoley Kojoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @timhoffm @tacaswell @Kojoley @jklymak