Skip to content

dviread: find_tex_file: Ensure the encoding on windows #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2018
Merged

dviread: find_tex_file: Ensure the encoding on windows #12351

merged 2 commits into from
Oct 2, 2018

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Sep 30, 2018

ref #11848 and #12253

@Kojoley Kojoley added this to the v3.0.x milestone Sep 30, 2018
@Kojoley Kojoley requested a review from anntzer September 30, 2018 12:59
@Kojoley Kojoley force-pushed the kpswitch-force-utf8-on-windows branch from 54fa028 to 6fd8b5b Compare September 30, 2018 13:09
@Kojoley Kojoley mentioned this pull request Sep 30, 2018
Merged
6 tasks
jklymak
jklymak reviewed Oct 2, 2018
View reviewed changes
@anntzer anntzer mentioned this pull request Oct 2, 2018
Closed
6 tasks
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 2, 2018
@anntzer anntzer modified the milestones: v3.0.x, v3.1 Oct 2, 2018
@jklymak
Copy link
Member

jklymak commented Oct 2, 2018

Leaving open a bit so @anntzer can double check his changes (look right to me)

Not sure if this one could have a test or not...

@anntzer anntzer merged commit 8d646e4 into matplotlib:master Oct 2, 2018
@anntzer
Copy link
Contributor

anntzer commented Oct 2, 2018

tests means: we should reenable tex tests on appveyor...

@Kojoley
Copy link
Member Author

Kojoley commented Oct 2, 2018

For some reason pytest hangs if TEST_ALL: "yes"...

@Kojoley Kojoley deleted the kpswitch-force-utf8-on-windows branch October 2, 2018 20:04
@pharshalp pharshalp mentioned this pull request Nov 21, 2018
Closed
@tacaswell tacaswell mentioned this pull request Feb 1, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/usetex
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kojoley @jklymak @anntzer