Skip to content

Remove some pytest parameterising warnings #12297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2018
Merged

Remove some pytest parameterising warnings #12297

merged 1 commit into from
Sep 26, 2018

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Sep 26, 2018 •
edited
Loading

Removes a bunch of warnings that look like

lib/mpl_toolkits/tests/test_mplot3d.py:129: RemovedInPytest4Warning: Applying marks directly to parameters is deprecated, please use pytest.param(..., marks=...) instead.
For more details, see: https://docs.pytest.org/en/latest/parametrize.html
  @image_comparison(baseline_images=['mixedsubplot'], remove_text=True,

@dstansby dstansby changed the title [WIP] Remove some pytest parameterising warnings Remove some pytest parameterising warnings Sep 26, 2018
@jklymak jklymak merged commit 47bfac4 into matplotlib:master Sep 26, 2018
@dstansby dstansby deleted the param-pytest branch September 26, 2018 16:09
@dstansby dstansby added this to the v3.1 milestone Sep 26, 2018
@QuLogic QuLogic mentioned this pull request Sep 27, 2018
Merged
2 tasks
@QuLogic
Copy link
Member

QuLogic commented Sep 29, 2018

@meeseeksdev backport to v3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 29, 2018
@jklymak
Backport PR matplotlib#12297: Remove some pytest parameterising warnings
6a92503
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 29, 2018
Merged
@dstansby dstansby modified the milestones: v3.1, v3.0.x Sep 29, 2018
dstansby added a commit that referenced this pull request Sep 29, 2018
@dstansby
Merge pull request #12339 from meeseeksmachine/auto-backport-of-pr-12…
2efbdd6 
…297-on-v3.0.x

Backport PR #12297 on branch v3.0.x (Remove some pytest parameterising warnings)
@timhoffm timhoffm mentioned this pull request Nov 17, 2018
Closed
@ArchangeGabriel
Copy link
Contributor

@meeseeksdev backport to v2.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 16, 2019

Awww, sorry ArchangeGabriel you do not seem to be allowed to do that, please ask a repository maintainer.

@ArchangeGabriel
Copy link
Contributor

ArchangeGabriel commented Jan 16, 2019 •
edited
Loading

OK, that was just to get the instructions as in #12154 (comment).

(EDIT: Figured them myself)

@ArchangeGabriel ArchangeGabriel mentioned this pull request Jan 16, 2019
Closed
@tacaswell
Copy link
Member

Thanks for digging into and getting these pytest issues fixed on the 2.2.x branch @ArchangeGabriel !

QuLogic added a commit that referenced this pull request Jan 22, 2019
@QuLogic
Merge pull request #13181 from ArchangeGabriel/auto-backport-of-pr-12…
4a5064c 
…154-on-v2.2.x

Backport PRs #12154, #12294, #12297, #12316, #13159 & #13205 to fix multiple tests issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
6 participants
@dstansby @QuLogic @ArchangeGabriel @tacaswell @anntzer @jklymak