Skip to content

Fix some warnings from Travis #12316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 29, 2018
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 27, 2018

PR Summary

These are pretty much deprecated items in our dependencies. Slightly related to #12297.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, subject to CI.

@QuLogic
Copy link
Member Author

QuLogic commented Sep 28, 2018

Looks like a lot more are triggered in AppVeyor. I will try to get to those later today.

@QuLogic QuLogic force-pushed the travis-warnings branch 2 times, most recently from 7877939 to 8942b07 Compare September 28, 2018 07:40
@QuLogic
Copy link
Member Author

QuLogic commented Sep 28, 2018

Managed to fix up a few more sets, from AppVeyor and macOS, due to missing dependencies triggering warnings in the checks.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the other parameterise fixes!

@dstansby dstansby added this to the v3.1 milestone Sep 29, 2018
@dstansby dstansby merged commit 85c9742 into matplotlib:master Sep 29, 2018
@QuLogic QuLogic deleted the travis-warnings branch September 29, 2018 19:01
@dstansby
Copy link
Member

dstansby commented Oct 6, 2018

@meesekesdev backport to v3.0.x

@QuLogic
Copy link
Member Author

QuLogic commented Oct 6, 2018

Note that since this would use pytest.param, it would bump the minimum pytest to 3.6, like @anntzer's PR. (Also, typo in the bot name.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants