-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix some warnings from Travis #12316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, subject to CI.
Looks like a lot more are triggered in AppVeyor. I will try to get to those later today. |
7877939
to
8942b07
Compare
Managed to fix up a few more sets, from AppVeyor and macOS, due to missing dependencies triggering warnings in the checks. |
Using pytest.param(..., marks=pytest.mark.something) is a different type than if using pytest.mark.something(...), so we need to handle that case on skipping extensions.
5beec56
to
d82d0f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the other parameterise fixes!
@meesekesdev backport to v3.0.x |
Note that since this would use |
PR Summary
These are pretty much deprecated items in our dependencies. Slightly related to #12297.
PR Checklist