Skip to content

Always install mpl_toolkits. #12317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Always install mpl_toolkits. #12317

merged 1 commit into from
Oct 11, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 28, 2018 •
edited
Loading

I don't think there's really a reason to make this configurable. Also
work towards auto-registering mplot3d (#12249 (comment)).

This PR also ensures that mpl_toolkits baseline images don't get
installed if mpl_toolkits tests are not installed (previously, the
baseline images would incorrectly be installed; that behavior goes back
to at least mpl1.5, and is also present on PyPI wheels). Given that the
baseline images are actually much heavier than the sources, this commit
will actually help decrease the weight of wheels by making baseline
images truly optional.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Always install mpl_toolkits.
fc73b77 
I don't think there's really a reason to make this configurable.  Also
work towards auto-registering mplot3d.

This PR also ensures that mpl_toolkits baseline images don't get
installed if mpl_toolkits tests are not installed (previously, the
baseline images would incorrectly be installed; that behavior goes back
to at least mpl1.5, and is also present on PyPI wheels).  Given that the
baseline images are actually much heavier than the sources, this commit
will actually help *decrease* the weight of wheels by making baseline
images truly optional.
@anntzer anntzer added the Build label Sep 28, 2018
@tacaswell tacaswell added this to the v3.1 milestone Sep 29, 2018
@tacaswell
Copy link
Member

attn @QuLogic @sandrotosi @felixonmars Do any of you use this option when packaging mpl?

tacaswell
tacaswell requested changes Sep 29, 2018
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nominally 👍 , but want sign off from down-stream packagers.

@tacaswell
Copy link
Member

Anyone can dismiss my review on feedback from packagers.

@QuLogic
Copy link
Member

QuLogic commented Sep 29, 2018

The only reason we use these options is to set them to True. While image test data is split, that's just done by specifying what files to include in each subpackage.

@anntzer
Copy link
Contributor Author

anntzer commented Sep 30, 2018

Arch doesn't do anything special here: the relevant files are https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/python-matplotlib and https://git.archlinux.org/svntogit/community.git/tree/trunk/setup.cfg?h=packages/python-matplotlib (https://git.archlinux.org/svntogit/community.git/tree/trunk?h=packages/python-matplotlib).

Looking at the relevant files in https://packages.debian.org/sid/python3-matplotlib (matplotlib_2.2.2-4.debian.tar.xz) I don't see anything specific either; their setup.cfg just sets

[rc_options]
# User-configurable options
#
# Default backend, one of: Agg, Cairo, CocoaAgg, GTK, GTKAgg,
# GTKCairo, FltkAgg, Pdf, Ps, QtAgg, Qt4Agg, SVG, TkAgg, WX, WXAgg.
#
# The Agg, Ps, Pdf and SVG backends do not require external
# dependencies. Do not choose GTK, GTKAgg, GTKCairo, TkAgg or WXAgg if
# you have disabled the relevent extension modules.  Agg will be used
# by default.
#
backend = TkAgg

[packages]
# install tests and baseline images
tests = True
toolkits_tests = True

[gui_support]
gtk = False
gtkagg = False

@tacaswell
Copy link
Member

Is this worth a api_changes note?

@tacaswell tacaswell merged commit 0f7367c into matplotlib:master Oct 11, 2018
@anntzer anntzer deleted the alwaystoolkits branch October 11, 2018 06:53
@anntzer
Copy link
Contributor Author

anntzer commented Oct 11, 2018

Wouldn't bother with it, as we're yet to find anyone who doesn't install them...

@sandrotosi
Copy link
Contributor

thanks @anntzer for checking debian too :) it's all good to me, obvi

@anntzer anntzer mentioned this pull request Feb 26, 2019
Merged
6 tasks
@tacaswell tacaswell mentioned this pull request Apr 20, 2019
Closed
@anntzer anntzer mentioned this pull request Apr 23, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @QuLogic @sandrotosi