Skip to content

Backport PR #12809 on branch v2.2.x (Fix TypeError when calculating tick_values) #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #12809: Fix TypeError when calculating tick_values

@lumberbot-app lumberbot-app bot added this to the v2.2.4 milestone Nov 15, 2018
@timhoffm
Copy link
Member

CI fails due to

E               _pytest.warning_types.RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
E               Please use node.get_closest_marker(name) or node.iter_markers(name).
E               Docs: https://docs.pytest.org/en/latest/mark.html#updating-code

Solution: Either pin pytest<3.8 or backport #12154.

@tacaswell
Copy link
Member

power cycled to re-run now that pytest pinning is merged.

@NelleV NelleV closed this Jan 18, 2019
@NelleV NelleV reopened this Jan 18, 2019
@ArchangeGabriel
Copy link
Contributor

@NelleV For the CI to pass (outside of MacOS that is just broken), #13181 must be merged first (or alternatively just part of it + alternative pinning of some deps).

@NelleV
Copy link
Member

NelleV commented Jan 19, 2019

@ArchangeGabriel there's actually two different problem right now. Tom and I have fixed them in a PR.

@ArchangeGabriel
Copy link
Contributor

@NelleV I think you fixed 3.0.x branch (PR #13216), but this is for 2.2.x.

@ArchangeGabriel
Copy link
Contributor

This can be cycled again, CI should now pass. :)

@timhoffm timhoffm closed this Jan 22, 2019
@timhoffm timhoffm reopened this Jan 22, 2019
@ArchangeGabriel
Copy link
Contributor

I don’t know what the coverage failure means, but outside from that all other CIs now pass.

@QuLogic QuLogic merged commit 1fc42b3 into matplotlib:v2.2.x Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants