Change Locator MAXTICKS checking to emitting a log at WARNING level. #13510
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Feb 25, 2019
I chose not to create a new helper method and instead change the behavior of raise_if_exceeds, so that third-party locators also benefit from the change.
|
At this point I'm neutral; I won't block it. It's not clear to me that on balance this is better or worse than its predecessor, #8100, or the alternative of doing nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose not to create a new helper method and instead change the
behavior of raise_if_exceeds, so that third-party locators also benefit
from the change.
Alternate for #8100 per #8100 (comment); closes #8089.
PR Summary
PR Checklist