-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate MAXTICKS, Locator.raise_if_exceeds. #8100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2503c3c
to
af930ce
Compare
I am conflicted on this. This limit came in via 0022de2 (and the comment says it is to prevent out of memory). On one hand, we have had several reports people running into this limit on machines that can handle it and we should not be putting artificial limits on things. On the other hand, if we raise, users can in principle recover where as if we just let things run out of memory they can not. On the third hand, rendering more than 1k ticks to the raster formats gets silly, there just are not enough pixels in most cases (and won't go so well with the vector formats either). I think the option here are:
|
Actually they can't even catch it (I think) because the exception is raised in the GUI thread during
We don't do anything for line plots or images (for which there's also a point of diminishing returns), I don't see why tickers should be different. |
They can catch it in the context of The difference between user supplied data and ticks is that if they hand us large volumes, it is on them to know what they are doing, but with ticks we do a lot more 'automagically' so need to be more careful. |
Fair enough. I have a strong suspicion that the number of people currently doing
is pretty low though :-) |
I like option 1. The limit was put in for a perfectly good reason, based on experience that is still relevant. |
As mentioned above, the limit can only help if one is using something like
(afaict, let me know if I missed other possibilities) and actually has a very negative impact (program abort) for programs using the Qt5 backend. As I said, I doubt there's much code in the wild using that pattern (if you're aware of that possibility you may as well make sure you won't trigger that code path by setting the tickers properly to start with). Unless you can prove me wrong, I would still favor removing the limit. |
af930ce
to
565d83f
Compare
565d83f
to
373b965
Compare
Still have not reached consensus on this, punting to 3.2 |
This does couple into the more recent work with logging, this may be a case where we want to change exceptions into log messages? |
Closed in favor of #13510. |
cf #8089.