Skip to content

Correctly handle invalid PNG metadata. #13923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

Correctly handle invalid PNG metadata. #13923

merged 1 commit into from
Apr 11, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 11, 2019

PR Summary

Fix the crash in #13902 due to invalid metadata. Not sure if I should bother with a test since #13902 will exercise it.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch.

@dstansby dstansby added this to the v3.2.0 milestone Apr 11, 2019
@dstansby dstansby merged commit f26774c into matplotlib:master Apr 11, 2019
@QuLogic QuLogic deleted the png-metadata-crash branch April 12, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: images
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @dstansby