Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PackerBase does not much. It just has an
__init__
that defines a common constructor and some attributes.I don't see a need for this base class to be visible to the end-user. By making it private we save the effort of documenting it (
__init__
docstrings have to be present in the derived classes because numpydoc does not inherit__init__
docstrings if there is a class docstring).We may also consider removing it alltogether later.