Skip to content

More cleanups. #14845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

More cleanups. #14845

merged 1 commit into from
Jul 19, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 18, 2019

  • transformA + transformB.inverted() === transformA - transformB,
    and give the result a more meaningful name.
  • Other cleanups in axislines.py (which used the above pattern quite a
    bit).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby
Copy link
Member

@anntzer can you try and work out why codecov isn't showing up on any of your PRs? I don't really want to review any until it returns...

@anntzer
Copy link
Contributor Author

anntzer commented Jul 18, 2019

I don't know why they don't show up on the gh interface, but they're actually being run; this PR is at https://codecov.io/gh/matplotlib/matplotlib/commit/2b4a3af41cb1168ef137efe5a2c052c3c735007d (you can find them under "recent commits" at https://codecov.io/gh/matplotlib/matplotlib).

@dstansby
Copy link
Member

Could you perhaps check with codecov why they're not showing up? Not having them easy to access/see just adds more effort on top of the already congested PR queue!

@anntzer
Copy link
Contributor Author

anntzer commented Jul 18, 2019

sure, will do

@anntzer
More cleanups.
7bf0185 
- `transformA + transformB.inverted()` === `transformA - transformB`,
  and give the result a more meaningful name.
- Other cleanups in axislines.py (which used the above pattern quite a
  bit).
@anntzer anntzer mentioned this pull request Jul 18, 2019
Merged
6 tasks
@anntzer
Copy link
Contributor Author

anntzer commented Jul 19, 2019

It's here now, it looks like it's just very delayed.

@QuLogic QuLogic added this to the v3.2.0 milestone Jul 19, 2019
@QuLogic QuLogic merged commit 18bc802 into matplotlib:master Jul 19, 2019
@anntzer anntzer deleted the inverted branch July 19, 2019 09:30
@anntzer anntzer mentioned this pull request Oct 1, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dstansby @QuLogic @timhoffm