More cleanups. #14845
Merged
More cleanups. #14845
+30
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 18, 2019
|
@anntzer can you try and work out why codecov isn't showing up on any of your PRs? I don't really want to review any until it returns... |
|
I don't know why they don't show up on the gh interface, but they're actually being run; this PR is at https://codecov.io/gh/matplotlib/matplotlib/commit/2b4a3af41cb1168ef137efe5a2c052c3c735007d (you can find them under "recent commits" at https://codecov.io/gh/matplotlib/matplotlib). |
|
Could you perhaps check with codecov why they're not showing up? Not having them easy to access/see just adds more effort on top of the already congested PR queue! |
|
sure, will do |
- `transformA + transformB.inverted()` === `transformA - transformB`, and give the result a more meaningful name. - Other cleanups in axislines.py (which used the above pattern quite a bit).
6 tasks
|
It's here now, it looks like it's just very delayed. |
QuLogic
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformA + transformB.inverted()===transformA - transformB,and give the result a more meaningful name.
bit).
PR Summary
PR Checklist