FIX: proper call to zero_formats #15181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
approved these changes
Sep 4, 2019
|
Would we need to draw the conclusion that |
|
Is it worth adding as a copy-paste smoke test the code in #15178 ? |
|
Could do, but I think a better route is some more tests. The feature is minimally tested at the moment. However, I don't have bandwidth for a few days (maybe w/e) whereas this bug fix should go it sooner rather than later. Starting a new issue for improving the tests and I promise to get them done ASAP.... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 4, 2019
jklymak
added a commit
that referenced
this pull request
Sep 4, 2019
…181-on-v3.1.x Backport PR #15181 on branch v3.1.x (FIX: proper call to zero_formats)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #15178
This was just a typo...
PR Checklist