FIX: be more forgiving about expecting internal state in draw_idle #15206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid race conditions with re-initing a new Qt5Agg canvas when: - in interactive mode - in plain python prompt - creating a second Qt5Agg canvas for an existing figure closes matplotlib#15205
ImportanceOfBeingErnest
approved these changes
Sep 6, 2019
dstansby
approved these changes
Sep 6, 2019
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Sep 6, 2019
…internal state in draw_idle Merge pull request matplotlib#15206 from tacaswell/fix_python_ion_second_qtcanvas_init FIX: be more forgiving about expecting internal state in draw_idle Conflicts: lib/matplotlib/tests/test_backend_qt.py - two tests were added on master, only kept the relevant one
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Sep 6, 2019
…internal state in draw_idle Merge pull request matplotlib#15206 from tacaswell/fix_python_ion_second_qtcanvas_init FIX: be more forgiving about expecting internal state in draw_idle Conflicts: lib/matplotlib/tests/test_backend_qt.py - no tests on this branch, did not backport test
6 tasks
QuLogic
added a commit
that referenced
this pull request
Sep 7, 2019
…-v3.1.x Backport PR #15206: FIX: be more forgiving about expecting internal s…
tacaswell
added a commit
that referenced
this pull request
Oct 15, 2019
…-v2.2.x Backport PR #15206: FIX: be more forgiving about expecting internal s…
|
Since 3.2.0 is about to be released, we can skip backporting to 3.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid race conditions with re-initing a new Qt5Agg canvas when:
closes #15205
PR Summary
PR Checklist