Backport PR #15206: FIX: be more forgiving about expecting internal s… #15208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal state in draw_idle Merge pull request matplotlib#15206 from tacaswell/fix_python_ion_second_qtcanvas_init FIX: be more forgiving about expecting internal state in draw_idle Conflicts: lib/matplotlib/tests/test_backend_qt.py - no tests on this branch, did not backport test
|
It is the same compilation problem on py37 on appveyor. |
|
I am in favor of merging this as-is without fixing the appveyor builds. |
timhoffm
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tate in draw_idle
Merge pull request #15206 from tacaswell/fix_python_ion_second_qtcanvas_init
FIX: be more forgiving about expecting internal state in draw_idle
Conflicts:
lib/matplotlib/tests/test_backend_qt.py
- no tests on this branch, did not backport test
PR Summary
PR Checklist