Skip to content

Fix DeprecationWarning in nightly testing #15403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

dstansby
Copy link
Member

Carrying on from #15168, there's a couple of other places where np.bool_ needs casting to bool to prevent a DeprecationWarning.

@dstansby
Copy link
Member Author

dstansby commented Oct 11, 2019

Looks like there's a few other places this needs fixing (I would mark this as needs changes if I could).

@tacaswell tacaswell added this to the v3.1.2 milestone Oct 11, 2019
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 11, 2019
@tacaswell
Copy link
Member

Sorry I missed these in #15168 😞 .

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as changes requested on behalf of @dstansby

Anyone can clear this.

@tacaswell
Copy link
Member

I have been busy recently and lost track of things, but it looks like this is not going to be fixed upstream so we need to get these fixes in, backported to 3.1.x and 2.2.x and get both tagged this weekend. I guess that is what I am doing on Sunday...

@dstansby dstansby dismissed tacaswell’s stale review October 12, 2019 09:22

Everything fixed

@tacaswell tacaswell modified the milestones: v3.1.2, v2.2.5 Oct 13, 2019
@story645 story645 merged commit ca9a411 into matplotlib:master Oct 13, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 13, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ca9a411030178b12e15ee525da0c2385dbcb8dbb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15403: Fix DeprecationWarning in nightly testing'
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-15403-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #15403 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 13, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ca9a411030178b12e15ee525da0c2385dbcb8dbb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15403: Fix DeprecationWarning in nightly testing'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-15403-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #15403 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@tacaswell
Copy link
Member

I'm looking at the backports, hopefully this is the same as #15168 and these code-paths don't exist on 2.2.x or 3.1.x.

@tacaswell tacaswell modified the milestones: v2.2.5, v3.3.0 Oct 13, 2019
@dstansby dstansby deleted the py38-fix branch October 13, 2019 20:33
@tacaswell
Copy link
Member

Yeah, these 3 are not on either 3.1.x or 2.2.x.

These came in via a60ac1a via #14609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants