-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix DeprecationWarning in nightly testing #15403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like there's a few other places this needs fixing (I would mark this as needs changes if I could). |
Sorry I missed these in #15168 😞 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as changes requested on behalf of @dstansby
Anyone can clear this.
I have been busy recently and lost track of things, but it looks like this is not going to be fixed upstream so we need to get these fixes in, backported to 3.1.x and 2.2.x and get both tagged this weekend. I guess that is what I am doing on Sunday... |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
I'm looking at the backports, hopefully this is the same as #15168 and these code-paths don't exist on 2.2.x or 3.1.x. |
Carrying on from #15168, there's a couple of other places where
np.bool_
needs casting tobool
to prevent a DeprecationWarning.