Skip to content

Remove mention that tkagg was derived from PIL. #15672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 11, 2019

It has basically been entirely rewritten (and rearchitected) by Matthew Brett and myself
(and others), at this point.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.3.0 milestone Nov 11, 2019
@tacaswell
Copy link
Member

The paint one was clear (that code is fully gone), I am less sure on this one. I am not sure how far you have deform code to no longer be considered "derived" ("this is my grand parent's axe, my parent replaced the handle and I replaced the head"). I would like to consult a lawyer before we merge this.

The baseline to compare to should be what ever the initial code was?

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want legal advice.

@tacaswell
Copy link
Member

I'm sending an email about this now via private channels.

@tacaswell
Copy link
Member

Update: legal is backed up, review is still pending.

@QuLogic
Copy link
Member

QuLogic commented Apr 1, 2020

Any update?

@tacaswell tacaswell self-assigned this Apr 1, 2020
@tacaswell
Copy link
Member

Re-pinged on the legal front.

If we do not need it, but carry it anyway I think there is little down side, but if we need to have it and strip it I think we are risking a relatively large down side (but IANAL), out of an abundance of caution pushing to 3.4.

@tacaswell tacaswell modified the milestones: v3.3.0, v3.4.0 May 28, 2020
@tacaswell
Copy link
Member

Sorry, the update on this got lost in my mental queue

The advice is to, if we are sure all the code has been re-written, we should add this text someplace in the docs:

"Where is PIL?
Many years ago, Matplotlib used to include code from PIL. Since then, the code has changed a lot - the organizing principle and methods of operation are now quite different. Because our review of the codebase showed that all the code that came from PIL was removed or rewritten, we have removed the PIL licensing information. If you want PIL, you can get it at ."

@anntzer
Copy link
Contributor Author

anntzer commented May 28, 2020

I can put that snippet at the top of tkagg.cpp if you want.

@tacaswell
Copy link
Member

That seems like a good place to put it.

It has basically been entirely rewritten by Matthew Brett and myself
(and others), at this point.
@anntzer
Copy link
Contributor Author

anntzer commented May 31, 2020

done

@QuLogic QuLogic requested a review from tacaswell June 2, 2020 23:31
@tacaswell tacaswell modified the milestones: v3.4.0, v3.3.0 Jun 5, 2020
@tacaswell tacaswell merged commit 62bc037 into matplotlib:master Jun 5, 2020
@anntzer anntzer deleted the pillicense branch June 5, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants