-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove mention that tkagg was derived from PIL. #15672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The paint one was clear (that code is fully gone), I am less sure on this one. I am not sure how far you have deform code to no longer be considered "derived" ("this is my grand parent's axe, my parent replaced the handle and I replaced the head"). I would like to consult a lawyer before we merge this. The baseline to compare to should be what ever the initial code was? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want legal advice.
I'm sending an email about this now via private channels. |
Update: legal is backed up, review is still pending. |
Any update? |
Re-pinged on the legal front. If we do not need it, but carry it anyway I think there is little down side, but if we need to have it and strip it I think we are risking a relatively large down side (but IANAL), out of an abundance of caution pushing to 3.4. |
Sorry, the update on this got lost in my mental queue The advice is to, if we are sure all the code has been re-written, we should add this text someplace in the docs:
|
I can put that snippet at the top of tkagg.cpp if you want. |
That seems like a good place to put it. |
It has basically been entirely rewritten by Matthew Brett and myself (and others), at this point.
done |
It has basically been entirely rewritten (and rearchitected) by Matthew Brett and myself
(and others), at this point.
PR Summary
PR Checklist