Colorbar cleanup. #15982
Merged
Colorbar cleanup. #15982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb6187c to
7890764
Compare
6 tasks
jklymak
reviewed
Jan 10, 2020
| @@ -715,6 +715,33 @@ def add_lines(self, CS): | |||
| #tlinewidths = [col.get_linewidth()[0] for lw in CS.collections] | |||
| ColorbarBase.add_lines(self, CS.levels, tcolors, tlinewidths) | |||
|
|
|||
| def update_normal(self, mappable): | |||
| """ | |||
There was a problem hiding this comment.
I guess this needs some sort of test while we are here....
There was a problem hiding this comment.
Given that axes_grid1.colorbar is already deprecated, I would rather not bother...
jklymak
approved these changes
Jan 10, 2020
timhoffm
approved these changes
Jan 10, 2020
|
May self-merge after CI resolving the conflict. |
Deprecate on_mappable_changed in favor of update_normal (they're the same now (except for a logging call) now that colorbars just use the norm of the mappable). Deprecate update_bruteforce in favor of update_normal -- it's not used anywhere except in axes_grid, but that's just because whoever introduced update_normal forgot to update axes_grid at the same time. axes_grid.colorbar is already deprecated but until its complete removal, we need to backport update_normal to it...
|
self-merge per above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate on_mappable_changed in favor of update_normal (they're the
same now (except for a logging call) now that colorbars just use the
norm of the mappable).
Deprecate update_bruteforce in favor of update_normal -- it's not used
anywhere except in axes_grid, but that's just because whoever introduced
update_normal forgot to update axes_grid at the same time.
axes_grid.colorbar is already deprecated but until its complete removal,
we need to backport update_normal to it...
PR Summary
PR Checklist