Reuse colorbar outline and patch when updating the colorbar. #15981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flake8: |
... so that changes to the outline edgecolor are kept.
|
oops, fixed |
c34d5d6 to
7051e7f
Compare
timhoffm
reviewed
Dec 20, 2019
Comment on lines
+1271
to
+1280
| self.outline = mpatches.Polygon( | ||
| np.empty((0, 2)), | ||
| edgecolor=mpl.rcParams['axes.edgecolor'], facecolor='none', | ||
| linewidth=mpl.rcParams['axes.linewidth'], closed=True, zorder=2) | ||
| self.ax.add_artist(self.outline) | ||
| self.outline.set(clip_box=None, clip_path=None) | ||
| self.patch = mpatches.Polygon( | ||
| np.empty((0, 2)), | ||
| color=mpl.rcParams['axes.facecolor'], linewidth=0.01, zorder=-1) | ||
| self.ax.add_artist(self.patch) |
There was a problem hiding this comment.
This code is repeated from __init__. Should this be moved to a private helper to remove duplication? Maybe only returning the outline and patch without adding them to ax within the helper?
There was a problem hiding this comment.
this is getting deprecated in #15982.
timhoffm
approved these changes
Dec 20, 2019
QuLogic
approved these changes
Mar 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that changes to the outline edgecolor are kept.
Closes #15980.
PR Summary
PR Checklist