Remove toolkit functions deprecated in 3.1 #15995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Dec 21, 2019
| @@ -863,7 +863,7 @@ Use the standard library's docstring manipulation tools instead, such as | |||
| These are considered internal and will be removed from the public API in a | |||
| future version. | |||
|
|
|||
| - `.projections.process_projection_requirements` | |||
| - ``projections.process_projection_requirements`` | |||
There was a problem hiding this comment.
these should technically be in a separate PR but I'm not going to be nitpicky with that.
There was a problem hiding this comment.
If one wants to be very strict yes, but it's just changing link to literal, which can be done anytime is not strictly related to the deprecation of that function. I saved the hassle of cherry-pickling parts of the file. 😄
anntzer
approved these changes
Dec 21, 2019
dstansby
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pulls out parts of #15890 to make that PR more managable and easier to debug the test failures.