Skip to content

Remove API deprecated in 3.1 (part 2) #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove API deprecated in 3.1 (part 2) #15890

wants to merge 1 commit into from

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Dec 9, 2019

PR Summary

Follow up and goes on top of to #15878. The are so many changes that I didn't want to put everything in one PR. Even in two parts, each part is quite long.

You may wait until #15878 is merged or just review the second commit in this PR.

@timhoffm timhoffm changed the title emove API deprecated in 3.1 (part 2) Remove API deprecated in 3.1 (part 2) Dec 9, 2019
@timhoffm
Copy link
Member Author

timhoffm commented Dec 9, 2019

For simplicity, will only fix the merge conflict after #15878 is in.

@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch from 99635c3 to f8bc395 Compare December 10, 2019 00:00
@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch from f8bc395 to 3ca63df Compare December 15, 2019 22:40
@timhoffm timhoffm added this to the v3.3.0 milestone Dec 15, 2019
@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch 2 times, most recently from 3c2ae89 to 0126cc1 Compare December 16, 2019 00:41
@anntzer
Copy link
Contributor

anntzer commented Dec 16, 2019

breakage is real

@timhoffm
Copy link
Member Author

The failure is due to incomplete removal of TextWithDash. Since removing that is a bit more involved, I've pulled this out to a separate PR #15950. Will come back here once that is merged.

@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch from 0126cc1 to 2b8eb2d Compare December 16, 2019 22:31
@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch from 2b8eb2d to 16c95a4 Compare December 16, 2019 23:38
@anntzer
Copy link
Contributor

anntzer commented Dec 17, 2019

Failures are real (bunch of mlab tests have to be deleted, in particular).

@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch 3 times, most recently from 6deea2a to 380962a Compare December 20, 2019 13:57
@timhoffm
Copy link
Member Author

Still some math-text related image comparison failures.

@anntzer
Copy link
Contributor

anntzer commented Dec 20, 2019

IIRC I had looked into this some time ago and the deprecation of stackrel may be the problematic one? in which case we can defer the removal of that part for now...

@timhoffm
Copy link
Member Author

I don't think it's \stackrel. This PR removes the command, but there were no usages of that anymore.

@timhoffm
Copy link
Member Author

Going to slice this down into smaller chunks to find out what is acutally causing the failure.

@timhoffm timhoffm mentioned this pull request Dec 21, 2019
Merged
@timhoffm timhoffm force-pushed the remove-3.1-deprecations2 branch from 380962a to de69bd8 Compare December 30, 2019 14:14
@timhoffm timhoffm mentioned this pull request Dec 30, 2019
Merged
@anntzer anntzer mentioned this pull request Jan 13, 2020
Merged
6 tasks
@anntzer
Copy link
Contributor

anntzer commented Jan 13, 2020

I think #16204/#16206 takes care of mathtext.

@anntzer anntzer mentioned this pull request Feb 5, 2020
Merged
6 tasks
@timhoffm timhoffm mentioned this pull request Feb 15, 2020
Merged
@timhoffm timhoffm mentioned this pull request Mar 14, 2020
Merged
@timhoffm timhoffm closed this Mar 14, 2020
@timhoffm
Copy link
Member Author

Replaced by the sequence of above PRs.

@timhoffm timhoffm deleted the remove-3.1-deprecations2 branch March 14, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

Assignees
No one assigned
Labels
API: changes Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timhoffm @anntzer