Skip to content

Deprecate update_datalim_bounds. #16025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

Deprecate update_datalim_bounds. #16025

merged 1 commit into from
Jan 6, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 26, 2019

This method was introduced in 56d43e6 with a note that it would be more
efficient to use it in some cases, then the note went away in ad74c3f
(2008) without the method ever being used either before or after. In
any case, it is simple enough to be reimplemented (possibly inline) if
we really need it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

dstansby
dstansby previously requested changes Dec 26, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is documented fairly well at current, I think the API note should list an alternative solution.

@anntzer anntzer force-pushed the update_datalim_bounds branch from 0c637a5 to 0013334 Compare December 26, 2019 21:16
@anntzer
Copy link
Contributor Author

anntzer commented Dec 26, 2019

Mentioned the alternative (which is just inlining the existing implementation).

@timhoffm timhoffm added this to the v3.3.0 milestone Jan 5, 2020
@anntzer anntzer force-pushed the update_datalim_bounds branch from 0013334 to cfa859e Compare January 5, 2020 22:05
@anntzer
Copy link
Contributor Author

anntzer commented Jan 5, 2020

rebased

@jklymak
Copy link
Member

jklymak commented Jan 6, 2020

sorry, too many merges and this needs to be rebased again...

@jklymak
Copy link
Member

jklymak commented Jan 6, 2020

... did it with the online editor.

@anntzer
Deprecate update_datalim_bounds.
93edb74 
This method was introduced in 56d43e6 with a note that it would be more
efficient to use it in some cases, then the note went away in ad74c3f
(2008) without the method ever being used either before or after.  In
any case, it is simple enough to be reimplemented (possibly inline) if
we really need it.
@anntzer anntzer force-pushed the update_datalim_bounds branch from 6e8587a to 93edb74 Compare January 6, 2020 17:20
@jklymak jklymak merged commit 3a2589b into matplotlib:master Jan 6, 2020
@anntzer anntzer deleted the update_datalim_bounds branch January 6, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby left review comments

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @dstansby