Make the signature of Axes.draw() consistent with Artist.draw(). #16063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b226b07 to
a663528
Compare
timhoffm
approved these changes
Jan 4, 2020
a500415 to
18a1b67
Compare
b5a493c to
32b5da6
Compare
QuLogic
approved these changes
Mar 9, 2020
lib/matplotlib/axes/_base.py
Outdated
| def draw(self, renderer=None, inframe=False): | ||
| # docstring inherited | ||
| if renderer is None: | ||
| cbook.warn_deprecated( | ||
| "3.3", message="Support for not passing the 'renderer' " | ||
| "paramater to Axes.draw() is deprecated since %(since)s and " |
There was a problem hiding this comment.
Suggested change
| "paramater to Axes.draw() is deprecated since %(since)s and " | |
| "parameter to Axes.draw() is deprecated since %(since)s and " |
lib/matplotlib/cbook/deprecation.py
Outdated
| @@ -323,6 +323,8 @@ def _delete_parameter(since, name, func=None): | |||
| such after the deprecation period has passed and the deprecated parameter | |||
| is removed. | |||
|
|
|||
| Additional kwargs are passed to `.warn_deprecated`. | |||
There was a problem hiding this comment.
Suggested change
| Additional kwargs are passed to `.warn_deprecated`. | |
| Additional keyword arguments are passed to `.warn_deprecated`. |
... i.e. draw(renderer) instead of draw(renderer=None, inframe=False) (with a deprecation period).
|
thanks, rebased and handled comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... i.e. draw(renderer) instead of draw(renderer=None, inframe=False)
(with a deprecation period).
Closes #16022.
PR Summary
PR Checklist