Expire deprecation of \stackrel #16206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16206 +/- ##
==========================================
- Coverage 80.87% 74.85% -6.02%
==========================================
Files 306 275 -31
Lines 75758 68664 -7094
Branches 9690 9686 -4
==========================================
- Hits 61268 51401 -9867
- Misses 11953 14907 +2954
+ Partials 2537 2356 -181
Continue to review full report at Codecov.
|
tacaswell
reviewed
Feb 7, 2020
| @@ -93,7 +93,6 @@ | |||
| r'$\operatorname{cos} x$', # github issue #553 | |||
| r'$\sum _{\genfrac{}{}{0}{}{0\leq i\leq m}{0<j<n}}P\left(i,j\right)$', | |||
| r"$\left\Vert a \right\Vert \left\vert b \right\vert \left| a \right| \left\| b\right\| \Vert a \Vert \vert b \vert$", | |||
| r'$\mathring{A} \stackrel{\circ}{A} \AA$', | |||
There was a problem hiding this comment.
Can we leave in the test as r'$\mathring{A} \AA$', ? I don't think we other wise have coverage of those symbols and it will avoid the re-numbering of the tests which is very confusing.
If we really want to drop this test, we should leave a None in place and filter it a bit farther down just before we feed paramaterize.
tacaswell
requested changes
Feb 7, 2020
timhoffm
approved these changes
Feb 8, 2020
|
Your patch looks fine to me. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Like #16204, but for \stackrel.
PR Checklist