Disable draw_foo methods on renderer used to estimate tight extents. #16734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Doesn't the renderer get cached, and thus needs these methods restored? |
|
The renderer gets swapped out later (in print_method) by a real one. This was already the case before: the |
tacaswell
approved these changes
Mar 13, 2020
timhoffm
reviewed
Mar 13, 2020
For the pgf backend, in particular draw_image() cannot succeed because that needs actual filesystem access (to set up \includegraphics).
e7fac8e to
cd519f8
Compare
QuLogic
approved these changes
Mar 13, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 14, 2020
…ed to estimate tight extents.
QuLogic
added a commit
that referenced
this pull request
Mar 14, 2020
…734-on-v3.2.x Backport PR #16734 on branch v3.2.x (Disable draw_foo methods on renderer used to estimate tight extents.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the pgf backend, in particular draw_image() cannot succeed because
that needs actual filesystem access (to set up \includegraphics).
I think this is a better solution than #16732 to close #16731, and should work both on master and backported to 3.2.
Note that this disabling of draw_foo methods was already done previously, in a piecemeal fashion, at https://github.com/matplotlib/matplotlib/blob/v3.2.0/lib/matplotlib/backends/backend_pgf.py#L422 or (in a different fashion) at https://github.com/matplotlib/matplotlib/blob/v3.2.0/lib/matplotlib/backends/backend_ps.py#L924.
PR Summary
PR Checklist