Skip to content

Path length #16888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Path length #16888

wants to merge 2 commits into from
+402 −24

Conversation

brunobeltran
Copy link
Contributor

@brunobeltran brunobeltran commented Mar 23, 2020 •
edited
Loading

PR Summary

To correctly compute the center of mass of a path (to e.g. center a marker correctly), we need to correctly compute the path lengths of the component Bezier curves.

Roadmap:

#16812 (*) <- #16832 (*) <- #16859 (*) <- (This PR) (*) <- #16889 (*) <- #16891 (MarkerStyle improvements!)

"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This was referenced Mar 23, 2020
Draft
Draft
Open
Merged
Merged
@brunobeltran brunobeltran force-pushed the path_length branch 9 times, most recently from e2f403a to 8d1e757 Compare March 31, 2020 02:03
@brunobeltran brunobeltran force-pushed the path_length branch 3 times, most recently from 23ffc9f to 0dbef92 Compare April 9, 2020 05:01
@jklymak jklymak marked this pull request as draft July 23, 2020 03:17
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jul 14, 2023
@jklymak
Copy link
Member

jklymak commented Jul 14, 2023

@brunobeltran your work on these path PRs was great. Appreciate that you have a real job now, but if you have any time to finish them, it would be a real service. Maybe your company allows donated hours?

@github-actions github-actions bot removed the status: inactive Marked by the “Stale” Github Action label Jul 17, 2023
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Sep 18, 2023
@greglucas
Copy link
Contributor

@rossbar @ksunden - Here is the PR I wanted to link you to for the bezier path things you were asking about today at the NumFOCUS summit. I think if anyone wants to pick this work up it would be very welcome and it has been laid out really nicely in the PR descriptions.

@story645 story645 added topic: path handling status: orphaned PR keep Items to be ignored by the “Stale” Github Action and removed status: waiting for other PR status: inactive Marked by the “Stale” Github Action labels Sep 6, 2024
@greglucas greglucas force-pushed the path_length branch 2 times, most recently from 4c50daf to 5c89fb3 Compare October 30, 2024 15:36
@greglucas greglucas marked this pull request as ready for review October 30, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keep Items to be ignored by the “Stale” Github Action status: orphaned PR status: work in progress topic: path handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunobeltran @jklymak @greglucas @QuLogic @story645