Skip to content

Making sure to keep over/under/bad in cmap resample/reverse. #16937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

greglucas
Copy link
Contributor

PR Summary

Setting the over/under/bad when calling _resample or reverse on the colormaps.

Fixes part of #16296
Addresses bullet 3 of this comment: #16296 (comment)

Could possibly be made a little more elegant using #14645
However, when I was working through this it isn't quite so simple as calling set_over() on the new_cmap object because you're calling it with None which can't be converted to a color on the other side. You also can't update thenew_cmap. _lut directly because when generating the cmap_d the _lut of all colormaps is not populated initially and it is still calling reverse().

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (postci)

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restarted the failed CI job (know to be flaky on CI).

@anntzer anntzer merged commit c292827 into matplotlib:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants