Making sure to keep over/under/bad in cmap resample/reverse. #16937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Setting the over/under/bad when calling _resample or reverse on the colormaps.
Fixes part of #16296
Addresses bullet 3 of this comment: #16296 (comment)
Could possibly be made a little more elegant using #14645
However, when I was working through this it isn't quite so simple as calling
set_over()
on the new_cmap object because you're calling it with None which can't be converted to a color on the other side. You also can't update thenew_cmap. _lut
directly because when generating thecmap_d
the_lut
of all colormaps is not populated initially and it is still calling reverse().PR Checklist