Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The code in the PR is preliminary. The deprecation may not be viable, pending discussion below.
Identified through the discussion in #17090.
Bbox.ignore()
introduces a persistent state that affects whetherBbox.update_from_path()
andBbox.update_from_data_xy()
will set the box extents to their arguments or join the argument extents with the existing extents. This hidden state can be confusing and is dangerous because it might be changed by other parts of the program without knowing.However,
matplotlib/lib/matplotlib/axes/_base.py
Line 2115 in 065769b
matplotlib/lib/matplotlib/testing/jpl_units/StrConverter.py
Line 114 in 065769b
made me think, if this feature is needed for ignoring data limits (which IMHO would be a questionable design). If so, we'd need a different approach.
Comments welcome.