Deprecate ismath parameter to draw_tex and ismath="TeX!". #17484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
May 23, 2020
This parameter is a bit confusing for backend implementers and actually effectively ignored (because draw_tex() already means "pass the entire string to usetex). Calling through draw_tex() was the only way, previously, to get `ismath="TeX!"` passed to `get_text_width_height_descent` (other than calling it manually), but that was handled identically to `ismath="TeX"` by some backends and just not supported by others. Again, folding "TeX!" into "TeX" makes the required API simpler for backend implementers.
|
yup |
timhoffm
approved these changes
May 24, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is a bit confusing for backend implementers and actually
effectively ignored (because draw_tex() already means "pass the entire
string to usetex).
Calling through draw_tex() was the only way, previously, to get
ismath="TeX!"passed toget_text_width_height_descent(other thancalling it manually), but that was handled identically to
ismath="TeX"by some backends and just not supported by others.Again, folding "TeX!" into "TeX" makes the required API simpler for
backend implementers.
PR Summary
PR Checklist