Skip to content

Fmaussion extended boundary norm #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 2, 2020

Conversation

efiring
Copy link
Member

@efiring efiring commented May 28, 2020

PR Summary

Rebase of #5034

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@efiring
Copy link
Member Author

efiring commented May 28, 2020

I still need to move the example from whats_new to a more appropriate place. Other than that, if I didn't mess up the rebase, it should be close to ready, at long last.

@efiring
Copy link
Member Author

efiring commented May 29, 2020

I left a modified example in the whats_new entry; it wasn't clear to me whether it should stay or go. I also modified the colormapnorms tutorial to add a panel illustrating the new kwarg, and to improve its overall clarity in the BoundaryNorm section (I think).

@efiring efiring added this to the v3.3.0 milestone May 29, 2020
@efiring
Copy link
Member Author

efiring commented May 29, 2020

Since this is a rebase (with a little tune-up) of an old PR that still had a v3.3 milestone, I added that milestone here; but this is by no means a blocker. Anyone who wants to punt it to 3.4 is welcome to do so.

@jklymak
Copy link
Member

jklymak commented May 29, 2020

I can't see the examples in the docs.... Is there a reason sometimes the artifacts link doesn't work?

@QuLogic
Copy link
Member

QuLogic commented May 30, 2020

The link doesn't work because @efiring has CircleCI enabled on his fork, and the linker assumes builds are done on the main repo. You can still find the docs by going to the regular build and clicking the Artifacts tab.

@efiring
Copy link
Member Author

efiring commented May 30, 2020

With CircleCI disabled on my fork now, I am closing and re-opening this to trigger the builds.

@efiring efiring closed this May 30, 2020
@efiring efiring reopened this May 30, 2020
@efiring
Copy link
Member Author

efiring commented May 30, 2020

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly doc clarifications.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
The substantive difference is that a ValueError is now raised
if BoundaryNorm is called with ncolors < the total number of
bins, including any extensions.
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, but it's an excuse to get Travis working again, at least.

Whitespace and wording tweaks.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants