-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fmaussion extended boundary norm #17534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fmaussion extended boundary norm #17534
Conversation
I still need to move the example from whats_new to a more appropriate place. Other than that, if I didn't mess up the rebase, it should be close to ready, at long last. |
I left a modified example in the whats_new entry; it wasn't clear to me whether it should stay or go. I also modified the colormapnorms tutorial to add a panel illustrating the new kwarg, and to improve its overall clarity in the BoundaryNorm section (I think). |
Since this is a rebase (with a little tune-up) of an old PR that still had a v3.3 milestone, I added that milestone here; but this is by no means a blocker. Anyone who wants to punt it to 3.4 is welcome to do so. |
I can't see the examples in the docs.... Is there a reason sometimes the artifacts link doesn't work? |
The link doesn't work because @efiring has CircleCI enabled on his fork, and the linker assumes builds are done on the main repo. You can still find the docs by going to the regular build and clicking the Artifacts tab. |
With CircleCI disabled on my fork now, I am closing and re-opening this to trigger the builds. |
See https://37861-1385122-gh.circle-artifacts.com/0/doc/build/html/tutorials/colors/colormapnorms.html#discrete-bounds for the modified tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly doc clarifications.
doc/users/next_whats_new/2020-05-28-extend_kwarg_to_BoundaryNorm.rst
Outdated
Show resolved
Hide resolved
doc/users/next_whats_new/2020-05-28-extend_kwarg_to_BoundaryNorm.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
The substantive difference is that a ValueError is now raised if BoundaryNorm is called with ncolors < the total number of bins, including any extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff, but it's an excuse to get Travis working again, at least.
doc/users/next_whats_new/2020-05-28-extend_kwarg_to_BoundaryNorm.rst
Outdated
Show resolved
Hide resolved
doc/users/next_whats_new/2020-05-28-extend_kwarg_to_BoundaryNorm.rst
Outdated
Show resolved
Hide resolved
Whitespace and wording tweaks. Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR Summary
Rebase of #5034
PR Checklist